update ionic.keyboard to support trigger.io keyboard module#4079
Closed
sloops77 wants to merge 2 commits intoionic-team:masterfrom
Closed
update ionic.keyboard to support trigger.io keyboard module#4079sloops77 wants to merge 2 commits intoionic-team:masterfrom
sloops77 wants to merge 2 commits intoionic-team:masterfrom
Conversation
Contributor
|
Hi @sloops77, thanks for the PR. For now, we've decided to keep the plugin focused on ours for simplicity (and making sure we can add new features in the future). However, if someone is using Ionic and forge together, hopefully they can apply your patch! |
Author
|
hey mlynch, Totally understand that you dont want to support this as it isnt your focus. Still - i am happy to support both this and ionic_keyboard port - even formally in some way if you wanna contact me to organise. I do the work anyway - so its no trouble for me to do this slightly more officially if you guys feel so inclined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds recognition for the trigger.io port of the keyboard module. See ionic-team/ionic-plugin-keyboard#114